Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding event when the user accepts camera permissions #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ivangarcia2
Copy link

I added an event when the user accept camera persmissions. This event will be true if there are cameras in the system or false if there are not.

I believe this is interesting to better control user interface messages.

@basst314
Copy link
Owner

basst314 commented Dec 2, 2021

Hi @ivangarcia2,
thanks for participating in this project! Looking at the diff, it seems like the new event emitter is triggered the same way as the existing cameraSwitched one - whenever a new camera stream is activated. This could be either initially when a user gave permissions, or when a user switched between cameras.
It looks like the new event emitter is redundant, in which case I'd rather stick to the exiting one.
Please let me know if I missed anything. Thanks!

For future reference, please keep file changes minimal and avoid reformatting existing code, this makes the diff harder to read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants